Update the cache row dim calculation in TBE SSD #4480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D77321062 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
q10
force-pushed
the
export-D77321062
branch
2 times, most recently
from
8e9bcfb to
656d0ba
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
|
This pull request was exported from Phabricator. Differential Revision: D77321062 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D77321062 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: Pull Request resolved: pytorch#4480 X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
q10
force-pushed
the
export-D77321062
branch
2 times, most recently
from
be04ecf to
04209be
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
|
This pull request was exported from Phabricator. Differential Revision: D77321062 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: Pull Request resolved: pytorch#4480 X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
|
This pull request was exported from Phabricator. Differential Revision: D77321062 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 14, 2025
Summary: Pull Request resolved: pytorch#4480 X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
Summary: X-link: facebookresearch/FBGEMM#1537 - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam. Reviewed By: emlin, jiawenliu64 Differential Revision: D77321062
|
This pull request was exported from Phabricator. Differential Revision: D77321062 |
|
This pull request has been merged in 619b6ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: - The current cache row dim calculation in TBE SSD assumes that optimizers have state sizes that are fixed relative to table dimensions. This change updates the cache row dim calculation to account for optimizers whose states' sizes depends on the row length, such as Partial Rowwise Adam.
Reviewed By: emlin, jiawenliu64
Differential Revision: D77321062